Fix mistakes in functions srgb_to_linear() and linear_to_srgb() #90187
+7
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clayjohn
reviewed
Apr 4, 2024
| @@ -174,16 +174,17 @@ struct _NO_DISCARD_ Color { | |||
|
|
|||
| _FORCE_INLINE_ Color srgb_to_linear() const { | |||
| return Color( | |||
| r < 0.04045f ? r * (1.0f / 12.92f) : Math::pow((r + 0.055f) * (float)(1.0 / (1.0 + 0.055)), 2.4f), | |||
There was a problem hiding this comment.
Multiply operations are slightly faster, so it cases like this, it's better to leave the multiplication in, otherwise you are adding CPU cycles where you don't have to.
Further, There is a subtle but real difference between * (1.0 / x) and / x which leads compilers to not optimize the line by replacing the divide with a multiply.
So this PR is likely adding CPU cycles at run time. Of course all compilers are slightly different, so the impact is hard to predict, but it's best not to remove the multiply.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The correct formulas uses "<=", not just "<".
This can be seen in IEC 61966-2-1:1999 or in the Wikipedia article "sRGB".
Also, some mathematical operations do not make sense and can be removed.