Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure Camera2D.position_smoothing_speed is non-negative. #90167

Merged
merged 1 commit into from
Apr 5, 2024
Merged

Ensure Camera2D.position_smoothing_speed is non-negative. #90167

merged 1 commit into from
Apr 5, 2024

Conversation

ajreckof
Copy link
Member

@ajreckof ajreckof commented Apr 3, 2024

Fixes #90154

@ajreckof ajreckof requested a review from a team as a code owner April 3, 2024 10:39
@AThousandShips AThousandShips changed the title Fix negative value for position_smoothing_speed being allowed. Ensure Camera2D.position_smoothing_speed is non-negative. Apr 3, 2024
@AThousandShips AThousandShips added this to the 4.3 milestone Apr 3, 2024
@KoBeWi
Copy link
Member

KoBeWi commented Apr 3, 2024

Rotation smoothing has the same problem.
You could also add setter guards.

@ajreckof ajreckof force-pushed the fix-negative-value-for-position_smoothing_speed-being-allowed branch from 8bfefb0 to 07406af Compare April 4, 2024 15:15
@akien-mga akien-mga merged commit fe78457 into godotengine:master Apr 5, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KoBeWi KoBeWi KoBeWi approved these changes

Assignees
No one assigned
Labels
bug topic:2d
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.

Unexpected behavior for negative values on Camera2D position_smoothing_speed
4 participants
@ajreckof @KoBeWi @akien-mga @AThousandShips