Improve string extraction of ETR POT file #90162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YeldhamDev
force-pushed
the
pot_future_proof
branch
from
65c60bb to
7bdae75
Compare
akien-mga
approved these changes
May 8, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of the additions of my recent work on auto-translation was that the strings from the "extract.pot" file are used to fill-in the generated POT from an user's project. This is done currently be loading the file with
TranslationLoaderPO, and while the file itself is a POT and not a PO, it works fine. However...I've done some extra testing, and if one of
ETRstring-types would happen to be a plural (usingETR_N()), this would cause it to break, because the way POT files store plurals is incompatible with howTranslationLoaderPOloads them. This PR fixes that by copying the function that extracts the data from the file and editing it to work specifically with POTs.