Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android: Remove redundant semicolons from Kotlin/gradle files #90147

Merged

Conversation

melquiadess
Copy link
Contributor

As in subject, probably a Java habit remnants ;)

Copy link
Member

@Calinou Calinou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense as per the Kotlin style guide: https://kotlinlang.org/docs/coding-conventions.html#semicolons

PS: Please double-check you've removed all semicolons from the Kotlin codebase (other than third-party files), so that we don't need a follow-up PR.

In the long run, we may want to set up a Kotlin linter/formatter on CI.

@melquiadess
Copy link
Contributor Author

melquiadess commented Apr 2, 2024

PS: Please double-check you've removed all semicolons from the Kotlin codebase (other than third-party files), so that we don't need a follow-up PR.

According to Android Studio - that is the case (the ones shown are valid)

image

But that reminds me - some .gradle files also contain a few stray semicolons - fix coming imminently... DONE

In the long run, we may want to set up a Kotlin linter/formatter on CI.

👍

@melquiadess melquiadess force-pushed the remove-redundant-semicolons branch from 54ce606 to 73908bb Compare April 2, 2024 22:33
@melquiadess melquiadess changed the title Remove redundant semicolons Remove redundant semicolons from Kotlin/gradle files Apr 2, 2024
Copy link
Contributor

@m4gr3d m4gr3d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@akien-mga akien-mga modified the milestones: 4.x, 4.3 Apr 3, 2024
@akien-mga akien-mga changed the title Remove redundant semicolons from Kotlin/gradle files Android: Remove redundant semicolons from Kotlin/gradle files Apr 4, 2024
@akien-mga akien-mga merged commit 82dd9b9 into godotengine:master Apr 4, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

@melquiadess melquiadess deleted the remove-redundant-semicolons branch April 8, 2024 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants