Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow drag and dropping ShaderMaterial in 3D viewport #90102

Merged
merged 1 commit into from
Apr 8, 2024
Merged

Allow drag and dropping ShaderMaterial in 3D viewport #90102

merged 1 commit into from
Apr 8, 2024

Conversation

themancalledjakob
Copy link
Contributor

Fixes #90075

@themancalledjakob themancalledjakob requested a review from a team as a code owner April 1, 2024 13:55
@AThousandShips AThousandShips changed the title allow drag and dropping ShaderMaterial in 3D viewport Allow drag and dropping ShaderMaterial in 3D viewport Apr 1, 2024
@AThousandShips AThousandShips added this to the 4.3 milestone Apr 1, 2024
fire
fire approved these changes Apr 2, 2024
View reviewed changes
Copy link
Member

@fire fire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't recall any reason why this would fail, but it's also a long time ago.

@akien-mga
Copy link
Member

For the record, your commit seems not to be linked to your GitHub account. See: Why are my commits linked to the wrong user? for more info.

@themancalledjakob
Copy link
Contributor Author

For the record, your commit seems not to be linked to your GitHub account. See: Why are my commits linked to the wrong user? for more info.

good catch! thanks

@akien-mga akien-mga merged commit f202ebb into godotengine:master Apr 8, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks! And congrats for your first merged Godot contribution 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fire fire fire approved these changes

Assignees
No one assigned
Labels
bug topic:editor topic:3d
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.

the "drag and drop a material on a mesh instance" does not work for a ShaderMaterial
5 participants
@themancalledjakob @akien-mga @fire @Calinou @AThousandShips