Fix issue with moving maximized window in macOS #90101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bruvzg
requested changes
Apr 1, 2024
There was a problem hiding this comment.
This will make the window movable by any unprocessed mouse event, which is not a desired behavior.
What's preventing window move in maximized mode is this condition:
It was added specifically to prevent moving maximized windows (probably to match behavior on the other platforms, I do not remember why it was done exactly).
|
The mentioned condition probably can be safely replaced with |
Jiali-Qiu
force-pushed
the
move-maximized-window
branch
from
e56319b to
ab00ee2
Compare
When opening the Godot editor and maximizing the window by double-clicking the title bar, users are unable to drag the window with the mouse. With this commit, `window_set_position` allows the maximized window to be moved by dragging it. Only the fullscreen window won't be allowed to move. Fixes godotengine#78758.
Jiali-Qiu
force-pushed
the
move-maximized-window
branch
from
ab00ee2 to
d78cb43
Compare
bruvzg
approved these changes
Apr 2, 2024
akien-mga
added
the
cherrypick:4.2
|
Thanks! And congrats for your first merged Godot contribution 🎉 |
|
Cherry-picked for 4.2.2. |
akien-mga
removed
the
cherrypick:4.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When opening the Godot editor and maximizing the window by double-clicking the title bar, users are unable to drag the window with the mouse.
With this commit,
window_set_positionallows the maximized window to be moved by dragging it. Only the fullscreen window won't be allowed to move.Fixes #78758.