- #90018
Closed
- #90018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seanluse41
changed the title
seanluse41
changed the title
|
Any reason this isn't just a suggestion on the relevant PR? Which was already suggested here: It really makes no sense to make a PR that changes the naming used in a different non-merged PR |
|
That's not how things are done, just because something hasn't changed in a while doesn't mean it's abandoned, there's nothing for you to submit here, please just comment on that PR and explain these changes We don't make new PRs taking someone else's work and adding to it unless it's been abandoned, and that's something to ask about, and two weeks isn't a long time in this case Please communicate :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.