Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove links to outdated asset library demos #89870

Closed
wants to merge 1 commit into from

Conversation

skyace65
Copy link
Contributor

@skyace65 skyace65 commented Mar 25, 2024

Bugsquad edit: superseded by #90310

This removes all links to demo projects in the asset library in the class reference, none of the demos are up to date for 4.x in the class reference, they're all on 3.5. I know there's an argument to be made that people can just convert the projects themselves, but we really shouldn't be asking that of users. I also worry we're wasting users time when they see a link and click on it only to find out it doesn't work for the current version, that doesn't give a great impression of the docs. In addition some of these probably need more thorough changes than others for 4.x like the navigation demos.

Closes godotengine/godot-docs#8055
Closes godotengine/godot-docs#7325
Closes godotengine/godot-docs#7423
Closes godotengine/godot-docs#6055
Closes godotengine/godot-docs#8247
Closes godotengine/godot-docs#7782
Closes godotengine/godot-docs#7000
Closes godotengine/godot-docs#8613

@skyace65 skyace65 requested review from a team as code owners March 25, 2024 01:29
@timothyqiu timothyqiu added this to the 4.3 milestone Mar 25, 2024
Copy link
Member

@fire fire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reasoning makes sense to remove. I did not check every single link to see if they're 3.5 though.

@rburing
Copy link
Member

rburing commented Mar 25, 2024

These may be outdated on the asset library, but their sources have probably already been updated, see https://github.com/godotengine/godot-demo-projects/. For those projects I think a better approach is to make a new release on the asset library, or link to the source instead.

See godotengine/godot-demo-projects#920

@akien-mga akien-mga requested a review from Calinou March 25, 2024 08:06
@AThousandShips
Copy link
Member

I'd say to remove them for now, and then update them, unless we do it very soon, it's been causing a lot of confusion and frustration

Though I'd suggest changing these links to point to the demo project repo instead

@AThousandShips
Copy link
Member

I can do a follow-up sweep and add demo links to the repo instead if desired, if not done in this

@rburing
Copy link
Member

rburing commented Mar 25, 2024

Note the asset library is much more accessible than a big GitHub repo, for ordinary users.

@AThousandShips
Copy link
Member

AThousandShips commented Mar 25, 2024

Indeed, meant mainly as a hold-over, as I recall the issue with updating the demos has been the lack of versioning support on the asset library, making it harder to have different versions there

Copy link
Member

@mhilbrunner mhilbrunner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, I think.

Alternatively, we could append something like "(3.x)" to the title of the links. If I was looking for something specific, it may still be useful to know some outdated tutorial is out there as a starting point to adapt from, rather than having nothing. Not sure.

@Calinou
Copy link
Member

Calinou commented Mar 25, 2024

I was planning to upload 4.x demos to the asset library (most demos linked here are already updated in godot-demo-projects' master branch).

The same goes for the TPS demo, although I wanted to get godotengine/tps-demo#181 merged before I tag a release for it.

@fire
Copy link
Member

fire commented Mar 25, 2024

I would argue that we should merge this to be at a good state and then merge in the changes for the new 4.x demos as they complete.

@skyace65
Copy link
Contributor Author

I was planning to upload 4.x demos to the asset library (most demos linked here are already updated in godot-demo-projects' master branch).

The same goes for the TPS demo, although I wanted to get godotengine/tps-demo#181 merged before I tag a release for it.

Do you have any estimate on when they'll be updated in the asset library?

@Calinou
Copy link
Member

Calinou commented Mar 28, 2024

Do you have any estimate on when they'll be updated in the asset library?

Ask and you shall receive 🙂

A few demos aren't uploaded yet as they still need to be updated: godotengine/godot-demo-projects#920 (comment)

@akien-mga
Copy link
Member

@skyace65 Can you update this PR to point to the new Godot 4 versions of these demos, instead of removing the links?

@mhilbrunner
Copy link
Member

mhilbrunner commented Apr 5, 2024

Seems the HDR demo was missed or not updated yet (although its missing in the list). Also, some titles/names of demos got changed, do we want to update the titles here too?

Edit: Updated the changes here to link to the now updated Asset Lib entries in #90310.

@akien-mga
Copy link
Member

Superseded by #90310.

@akien-mga akien-mga closed this Apr 7, 2024
@akien-mga akien-mga removed this from the 4.3 milestone Apr 7, 2024
@Calinou
Copy link
Member

Calinou commented Apr 8, 2024

Seems the HDR demo was missed or not updated yet (although its missing in the godotengine/godot-demo-projects#920 (comment)). Also, some titles/names of demos got changed, do we want to update the titles here too?

For future reference, see godotengine/godot-demo-projects#920 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment