Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve some notification and translation docs #89815

Merged
merged 1 commit into from
Mar 25, 2024

Conversation

KoBeWi
Copy link
Member

@KoBeWi KoBeWi commented Mar 23, 2024

Closes #89804

@KoBeWi KoBeWi added this to the 4.3 milestone Mar 23, 2024
@KoBeWi KoBeWi requested a review from a team as a code owner March 23, 2024 16:54
@YeldhamDev
Copy link
Member

YeldhamDev commented Mar 23, 2024

Before this is merged, I would like to tackle a way that makes the current behavior people use to update texts still work.

See below.

@KoBeWi KoBeWi force-pushed the translates_bananas branch from a67cf7b to 1382cdc Compare March 23, 2024 19:10
@Kiisu-Master
Copy link
Contributor

On the NOTIFICATION_TRANSLATION_CHANGED doc also mention it gets sent when setting auto translate mode. It seems like a important thing and I kind of forgot about that. When creating the issue, I thought it only gets sent when changing locale or smth (as I have never had a reason to set the auto translate mode at runtime).

@YeldhamDev
Copy link
Member

I thought it only gets sent when changing locale or smth

The current naming definitely doesn't help. We discussed in the dev chat that also the opportunity arrives, to replace _CHANGED with _UPDATED.

Also, I'm afraid that people will have to adapt to the new way of doing it. As I can't think of a way to support the old behavior without over-complicating things.

@KoBeWi KoBeWi force-pushed the translates_bananas branch from 1382cdc to 8378942 Compare March 24, 2024 14:14
@KoBeWi
Copy link
Member Author

KoBeWi commented Mar 24, 2024

On the NOTIFICATION_TRANSLATION_CHANGED doc also mention it gets sent when setting auto translate mode.

Done.

@akien-mga akien-mga merged commit 0e36df6 into godotengine:master Mar 25, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

@KoBeWi KoBeWi deleted the translates_bananas branch March 25, 2024 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NOTIFICATION_TRANSLATION_CHANGED gets sent at wrong times
5 participants