Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add necessary flags when opening directory with xfce4-terminal #89803

Merged
merged 1 commit into from
Apr 9, 2024
Merged

Add necessary flags when opening directory with xfce4-terminal #89803

merged 1 commit into from
Apr 9, 2024

Conversation

timothyqiu
Copy link
Member

It needs the --working-directory flag to work properly. Otherwise nothing opens.

@timothyqiu timothyqiu added this to the 4.3 milestone Mar 23, 2024
@timothyqiu timothyqiu requested a review from a team as a code owner March 23, 2024 12:45
Calinou
Calinou approved these changes Apr 8, 2024
View reviewed changes
Copy link
Member

@Calinou Calinou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not tested on my end (I don't have Xfce installed), but this seems logical.

@akien-mga akien-mga merged commit 3c4c79c into godotengine:master Apr 9, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

@timothyqiu timothyqiu deleted the xfce4-terminal branch April 9, 2024 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Calinou Calinou Calinou approved these changes

Assignees
No one assigned
Labels
enhancement platform:linuxbsd topic:editor
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.
3 participants
@timothyqiu @akien-mga @Calinou