Improve the editor native shader source visualizer #89690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Geometror
reviewed
Mar 21, 2024
Geometror
approved these changes
Mar 21, 2024
- Use CodeEdit to enable features such as line numbers and minimap. - Enable syntax highlighting. - Use a fixed-width font. - Use the script editor settings.
Calinou
force-pushed
the
editor-improve-native-shader-inspector
branch
from
07682d4 to
44de95e
Compare
akien-mga
closed this pull request by merging all changes
into
godotengine:master
in
06abc86
akien-mga
added a commit
that referenced
this pull request
Mar 24, 2024
…nspector Improve the editor native shader source visualizer
|
Thanks! |
jsjtxietian
reviewed
May 6, 2024
|
|
||
| // Colorize preprocessor statements. | ||
| const Color user_type_color = EDITOR_GET("text_editor/theme/highlighting/user_type_color"); | ||
| syntax_highlighter->add_color_region("#", "", user_type_color, true); |
There was a problem hiding this comment.
Since we have #85014 merged, should we add a syntax_highlighter->set_uint_suffix_enabled() here too?
There was a problem hiding this comment.
Sure, feel free to open a PR for this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The native shader source visualizer is the option from this dropdown:
Performance (in terms of the time it takes for the dialog to open) is roughly the same as before.
Preview
Before
After