GDScript: Do not produce UNUSED_SIGNAL warning for common implicit uses
#89675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dalexeev
force-pushed
the
gds-correct-unused-signal-warning
branch
from
9340a2b to
d1e2afa
Compare
adamscott
reviewed
Apr 23, 2024
dalexeev
added
the
cherrypick:4.3
akien-mga
approved these changes
Sep 5, 2024
There was a problem hiding this comment.
Seems good to me. I confirm it fixes two false positives of this warning in gdquest-demos/godot-4-3d-third-person-controller#41 (superseded that PR).
I still have doubts on whether this warning is worth keeping giving its (apparently unsolvable) limitations, but I see no harm in doing this improvement for now to solve some known false positives.
Mickeon
approved these changes
Sep 5, 2024
|
Cherry-picked for 4.3.1. |
akien-mga
removed
the
cherrypick:4.3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 4.x, signals are first class values, but sometimes people use the old API and implicitly reference signals via strings.
With this PR the
UNUSED_SIGNALwarning is not produced in the following cases:Signal(self, <constant signal name>);emit_signal(),connect(), anddisconnect()with constant signal name.