[Doc] Clarify behavior of String.format with keys in replacements
#89608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AThousandShips
added
enhancement
documentation
cherrypick:4.1
AThousandShips
force-pushed
the
format_doc_fix
branch
from
cae45a5 to
8a78e7e
Compare
mhilbrunner
approved these changes
Apr 6, 2024
|
Thanks! |
|
Thank you! |
|
Cherry-picked for 4.2.2. |
akien-mga
removed
the
cherrypick:4.2
|
Cherry-picked for 4.1.4. |
akien-mga
removed
the
cherrypick:4.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While this might be unreliable and unpredictable it is valid use of formatting and changing it would be break things IMO, and is a very old feature, so I'd prefer to document this over changing the code
Would need to be added to the format strings docs as well (which talks about this method).
String.formatdepends on the order of passed values, resulting in unwanted replacements. #89604