Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix gdextensionlibs.json storage path in Android gradle build #89579

Merged
1 commit merged into from
Mar 24, 2024

Conversation

beicause
Copy link
Contributor

Fix #89062

@beicause beicause requested a review from a team as a code owner March 16, 2024 16:47
@AThousandShips
Copy link
Member

Please make your commit message and PR title more descriptive :)

It should relative to gradle build directory
@beicause beicause changed the title fix gradle build gdextensionlibs.json store path Fix gdextensionlibs.json storage path in Android gradle build Mar 16, 2024
Copy link
Contributor

@m4gr3d m4gr3d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for tracking the issue!

@akien-mga akien-mga changed the title Fix gdextensionlibs.json storage path in Android gradle build Fix gdextensionlibs.json storage path in Android gradle build Mar 23, 2024
@akien-mga akien-mga closed this pull request by merging all changes into godotengine:master in 06abc86 Mar 24, 2024
akien-mga added a commit that referenced this pull request Mar 24, 2024
Fix `gdextensionlibs.json` storage path in Android gradle build
@akien-mga
Copy link
Member

Thanks! And congrats for your first merged Godot contribution 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Godot crashed when Gradle builds for Android with GDExtension in 4.3
4 participants