-
-
Notifications
You must be signed in to change notification settings - Fork 21.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix mobile renderer RID leaks #89531
Conversation
servers/rendering/renderer_rd/storage_rd/render_scene_buffers_rd.cpp
Outdated
Show resolved
Hide resolved
servers/rendering/renderer_rd/storage_rd/render_scene_buffers_rd.cpp
Outdated
Show resolved
Hide resolved
servers/rendering/renderer_rd/storage_rd/render_scene_buffers_rd.cpp
Outdated
Show resolved
Hide resolved
servers/rendering/renderer_rd/forward_mobile/render_forward_mobile.cpp
Outdated
Show resolved
Hide resolved
Update render_forward_mobile destructor to include instance buffers. Update render_scene_buffers_rd cleanup to include weight buffers / blur textures.
1b07709
to
dfa326e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! Thank you for fixing this
Code changes look good to me, given the nature of the changes, I trust that they are good given that they are passing CI
This should be an easy cherrypick too
Fix mobile renderer RID leaks
06abc86
Thanks! And congrats for your first merged Godot contribution 🎉 |
Cherry-picked for 4.2.2. |
Update render_forward_mobile destructor to include instance buffers.
Update render_scene_buffers_rd cleanup to include weight buffers / blur textures.
Fixes: #89182