Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow BaseMaterial3D height/dither fade to work with Compatibility rendering #89528

Conversation

Calinou
Copy link
Member

@Calinou Calinou commented Mar 15, 2024

Compatibility is based on OpenGL ES 3.0, so the height shader (including deep parallax) and distance fade dither modes work just fine with no adjustments required.

Testing project: test_height_compatibility.zip

Preview

Forward+

Screenshot_20240315_185642 webp

Compatibility

Screenshot_20240315_185703 webp

@Calinou Calinou added this to the 4.x milestone Mar 15, 2024
@Calinou Calinou force-pushed the basematerial3d-height-allow-in-compatibility branch from 4155c86 to f8a9b03 Compare March 15, 2024 18:04
@Calinou Calinou changed the title Allow BaseMaterial3D height to work with the Compatibility rendering method Allow BaseMaterial3D height/dither fade to work with Compatibility rendering Mar 15, 2024
@Calinou Calinou added bug and removed enhancement labels Jun 20, 2024
@Calinou Calinou modified the milestones: 4.x, 4.3 Jun 20, 2024
Copy link

@LBranco27 LBranco27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2024-06-21.13-20-28.mp4

Copy link
Member

@clayjohn clayjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Sorry this slipped through the cracks.

@clayjohn clayjohn added the cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release label Jun 21, 2024
@clayjohn clayjohn modified the milestones: 4.x, 4.3 Jun 21, 2024
…ndering

Compatibility is based on OpenGL ES 3.0, so the height shader
(including deep parallax) and distance fade dither modes work
just fine with no adjustments required.
@Calinou Calinou force-pushed the basematerial3d-height-allow-in-compatibility branch from f8a9b03 to 281e0e6 Compare June 21, 2024 22:57
@akien-mga akien-mga merged commit 41cc256 into godotengine:master Jun 22, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

@Calinou Calinou deleted the basematerial3d-height-allow-in-compatibility branch June 22, 2024 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release topic:rendering topic:3d
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Distance Fade PixelDither and ObjectDither does not work when usign Compatibility Rendering
4 participants