Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix description of touch input position #89509

Merged
merged 1 commit into from
Mar 15, 2024

Conversation

timothyqiu
Copy link
Member

InputEventScreen{Touch,Drag}.position is in viewport coordinates.

Related engine codes are all using get_global_transform_with_canvas() to transform position to local coordinates.

@timothyqiu timothyqiu added this to the 4.3 milestone Mar 15, 2024
@timothyqiu timothyqiu requested a review from a team as a code owner March 15, 2024 08:56
@akien-mga akien-mga added the cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release label Mar 15, 2024
@akien-mga akien-mga merged commit 856efe4 into godotengine:master Mar 15, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

@timothyqiu timothyqiu deleted the touch-event-position branch March 15, 2024 09:55
@akien-mga akien-mga added the cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release label Apr 8, 2024
@akien-mga
Copy link
Member

Cherry-picked for 4.2.2.

@akien-mga akien-mga removed the cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release label Apr 8, 2024
@akien-mga
Copy link
Member

Cherry-picked for 4.1.4.

@akien-mga akien-mga removed cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release topic:input labels Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants