Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RTL] Use "visible characters" property for inline object visibility #89395

Merged
merged 1 commit into from
Mar 12, 2024
Merged

[RTL] Use "visible characters" property for inline object visibility #89395

merged 1 commit into from
Mar 12, 2024

Conversation

bruvzg
Copy link
Member

@bruvzg bruvzg commented Mar 11, 2024

  • Adds helper methods to the TextServer to find inline object character range and associated glyph index.
  • Adds inline object visibility checks to the RTL (for After Shaping visible characters/glyphs modes).

Fixes #89373

@bruvzg bruvzg added this to the 4.x milestone Mar 11, 2024
@bruvzg bruvzg marked this pull request as ready for review March 12, 2024 08:56
@bruvzg bruvzg requested review from a team as code owners March 12, 2024 08:56
@akien-mga akien-mga modified the milestones: 4.x, 4.3 Mar 12, 2024
@bruvzg bruvzg force-pushed the rtl_ts_img_range branch from 23645d7 to 433de7f Compare March 12, 2024 09:29
@akien-mga akien-mga merged commit 061e0c7 into godotengine:master Mar 12, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

@bruvzg bruvzg mentioned this pull request Apr 8, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
enhancement topic:gui
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.

RichTextLabel: visible_characters does not hide [img] embeds when behaviour is characters after shaping
2 participants
@bruvzg @akien-mga