Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce \n eol for Python writes #89333

Merged
merged 1 commit into from
Mar 9, 2024

Conversation

Repiteo
Copy link
Contributor

@Repiteo Repiteo commented Mar 9, 2024

Primarily created with the intent of fixing a pre-commit hook bug causing eol to change to CRLF on Windows machines, which was fixed by enforcing \n eol on-write in copyright_headers.py. However, realizing that this eol specification isn't really used elsewhere in the repo, in constrast to .gitattributes expecting it at all times, this branched out to applying that specification to all relevant file writes across every Python script. Additionally, while largly superfluous, this also enforces utf-8 encoding for file writes if previously unspecified.

• Ensure utf-8 encoding if previously unspecified
@Repiteo Repiteo requested review from a team as code owners March 9, 2024 20:39
Copy link
Contributor

@Riteo Riteo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@akien-mga akien-mga merged commit 0ace0a1 into godotengine:master Mar 9, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants