Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add keywords to PhysicsBody{2D,3D}.test_move() for easier discoverability #89318

Merged
merged 1 commit into from
Mar 9, 2024
Merged

Add keywords to PhysicsBody{2D,3D}.test_move() for easier discoverability #89318

merged 1 commit into from
Mar 9, 2024

Conversation

Calinou
Copy link
Member

@Calinou Calinou commented Mar 9, 2024

@Calinou
Add keywords to PhysicsBody{2D,3D}.test_move() for easier discovera…
f8dd984 
…bility

`sweep` is the term used in Unity for collision checks without
moving anything.
@Calinou Calinou requested a review from a team as a code owner March 9, 2024 16:33
@Calinou Calinou added this to the 4.3 milestone Mar 9, 2024
Mickeon
Mickeon approved these changes Mar 9, 2024
View reviewed changes
Copy link
Contributor

@Mickeon Mickeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure

I'd give it check_collision but keywords are a bit weird right now when matching for the same keyword.

@akien-mga akien-mga merged commit b2b7ea2 into godotengine:master Mar 9, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

@Calinou Calinou deleted the doc-test-move-keywords branch March 13, 2024 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mickeon Mickeon Mickeon approved these changes

Assignees
No one assigned
Labels
documentation enhancement
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.
3 participants
@Calinou @akien-mga @Mickeon