Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows: Avoid scale_with_dpi constexpr compiler error. #89303

Merged
merged 1 commit into from
Mar 9, 2024

Conversation

fire
Copy link
Member

@fire fire commented Mar 9, 2024

IsProcessDPIAware() is not a const expression causing compiles to fail.

I'll try to get full bug report soon. I can't find the recreation steps. I think it's like using mingw on a mac.

@fire fire requested a review from a team as a code owner March 9, 2024 00:48
@akien-mga akien-mga changed the title Avoid scale_with_dpi constexpr compiler error. Windows: Avoid scale_with_dpi constexpr compiler error. Mar 9, 2024
@akien-mga akien-mga added this to the 4.3 milestone Mar 9, 2024
@akien-mga akien-mga merged commit f289648 into godotengine:master Mar 9, 2024
16 checks passed
@akien-mga akien-mga deleted the scale-with-dpi-constexpr-4.3 branch March 9, 2024 09:19
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants