Fix audio listener crash in stream player #89230
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
reviewed
Mar 6, 2024
| @@ -140,6 +140,7 @@ void AudioStreamPlayer2D::_update_panning() { | |||
|
|
|||
| //screen in global is used for attenuation | |||
| AudioListener2D *listener = vp->get_audio_listener_2d(); | |||
| ERR_FAIL_NULL(listener); | |||
There was a problem hiding this comment.
How does it fix a crash? The use of listener before is guarded by if (listener) (which is now made redundant so the else branch would be dead code.
There was a problem hiding this comment.
Huh, that's a good question. It does fix the crash though, I posted stack trace in the issue. But it doesn't make sense .-.
Also I misunderstood what is_audio_listener_2d() is supposed to do.
My guess would be that listener pointer is invalid and this "fix" worked by a pure luck. It completely breaks audio playback though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the crash in #89212
This is probably a deeper issue though.
is_audio_listener_2d()is supposed to ensure that listener exists, but it doesn't. Maybe there is some threading involved here.The problem seems to exist only in 2D.