-
-
Notifications
You must be signed in to change notification settings - Fork 21.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix some missing categories in visual shader nodes #89190
Conversation
@@ -75,8 +75,6 @@ class VisualShaderNodeParticleSphereEmitter : public VisualShaderNodeParticleEmi | |||
virtual String generate_global_per_node(Shader::Mode p_mode, int p_id) const override; | |||
virtual String generate_code(Shader::Mode p_mode, VisualShader::Type p_type, int p_id, const String *p_input_vars, const String *p_output_vars, bool p_for_preview = false) const override; | |||
|
|||
virtual Category get_category() const override { return CATEGORY_PARTICLE; } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These were redundant as the parent type already does this
@@ -1990,8 +2010,6 @@ class VisualShaderNodeVectorDecompose : public VisualShaderNodeVectorBase { | |||
virtual void set_op_type(OpType p_op_type) override; | |||
virtual String generate_code(Shader::Mode p_mode, VisualShader::Type p_type, int p_id, const String *p_input_vars, const String *p_output_vars, bool p_for_preview = false) const override; | |||
|
|||
virtual Category get_category() const override { return CATEGORY_VECTOR; } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was redundant
@@ -49,6 +49,8 @@ class VisualShaderNodeSDFToScreenUV : public VisualShaderNode { | |||
|
|||
virtual String generate_code(Shader::Mode p_mode, VisualShader::Type p_type, int p_id, const String *p_input_vars, const String *p_output_vars, bool p_for_preview = false) const override; | |||
|
|||
virtual Category get_category() const override { return CATEGORY_TEXTURES; } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm unsure exactly what category to assign these to
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We might want to add a new category for SDF nodes in the future. Or we just use CATEGORY_TEXTURES
or CATEGORY_SPECIAL
, at least that's what I would do for now.
Thanks! |
Thank you! |
Confirmed these with: