Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Editable Children menu action to be keyboard shortcuttable #89142

Merged
merged 1 commit into from
Mar 4, 2024

Conversation

miv391
Copy link
Contributor

@miv391 miv391 commented Mar 4, 2024

Fixes godotengine/godot-proposals#9229

Makes the Editable Children action in scene tree menu keyboard shortcuttable. No default shortcut is set.

@miv391 miv391 requested a review from a team as a code owner March 4, 2024 13:13
@KoBeWi KoBeWi added this to the 4.3 milestone Mar 4, 2024
@AThousandShips AThousandShips changed the title Changed Editable Children menu action to be keyboard shortcuttable Change Editable Children menu action to be keyboard shortcuttable Mar 4, 2024
@AThousandShips
Copy link
Member

You also need to add this shortcut at line 3457

@KoBeWi
Copy link
Member

KoBeWi commented Mar 4, 2024

Since the action had no shortcut, it never had a safeguard against invalid usage. Which means that you can use it on a node that isn't an instance and it will still toggle editable children as if it was an instance (even with a warning when disabling).

You need to add a condition in case the shortcut is used when the option is not available for selected node(s).

@miv391 miv391 force-pushed the shortcut-to-editable-children branch from 4f424f7 to 6589d00 Compare March 4, 2024 15:53
@miv391
Copy link
Contributor Author

miv391 commented Mar 4, 2024

You also need to add this shortcut at line 3457

Fixed.

You need to add a condition in case the shortcut is used when the option is not available for selected node(s).

Fixed.

editor/scene_tree_dock.cpp Outdated Show resolved Hide resolved
@miv391 miv391 force-pushed the shortcut-to-editable-children branch from 6589d00 to 3c0b66b Compare March 4, 2024 16:32
@akien-mga akien-mga merged commit cc3457b into godotengine:master Mar 4, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

@miv391 miv391 deleted the shortcut-to-editable-children branch March 4, 2024 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a shortcut to toggle Editable Children
4 participants