Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing variablesReference field to DAP evaluate request #89110

Merged
merged 1 commit into from
Mar 4, 2024

Conversation

rsubtil
Copy link
Contributor

@rsubtil rsubtil commented Mar 3, 2024

Fixes #89052

As @dekaravanhoc noted, the DAP spec for the evaluate request requires a variablesReference field to be set.

Since Godot fully parses the given expression, this field is hardcoded to 0 according to the spec behavior:

/**
* If variablesReference is > 0, the evaluate result is structured and its
* children can be retrieved by passing variablesReference to the
* variables request as long as execution remains suspended. See 'Lifetime
* of Object References' in the Overview section for details.
*/

@rsubtil rsubtil requested a review from a team as a code owner March 3, 2024 11:25
@akien-mga akien-mga added bug topic:editor cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release labels Mar 3, 2024
@akien-mga akien-mga added this to the 4.3 milestone Mar 3, 2024
@akien-mga akien-mga merged commit faafccb into godotengine:master Mar 4, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

@rsubtil rsubtil deleted the fix_missing_field_on_dap_req branch March 4, 2024 13:22
@akien-mga
Copy link
Member

Cherry-picked for 4.2.2.

@akien-mga akien-mga removed the cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release label Mar 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Godot Debug Adapter Response is missing required field variablesReference in EvaluateResponse
2 participants