Fix RandomNumberGenerator::rand_weighted
return type
#89104
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes wrong return type introduced in #88883:
RandomNumberGenerator::rand_weighted
returnsint
instead ofint64_t
(the returned valuei
is defined asint64_t
inside thefor
loop).Also made minor changes to the documentation example (few typos).
As a side note, can we change the internal
RandomPCG::rand_weighted
method name torandom_weighted
(all other methods here are just calledrandom
)? The exposed one fromRandomNumberGenerator
would remain the samerand_weighted
.