Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix FileAccessUnix on OpenBSD where UF_HIDDEN isn't supported #89064

Merged
merged 1 commit into from
Mar 4, 2024

Conversation

omar-polo
Copy link
Contributor

Part of the joint effort with @rfht to port Godot 4 on OpenBSD.

Part of the joint effort with @rfht to port Godot 4 on OpenBSD.
Copy link
Contributor

@Riteo Riteo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know much about OpenBSD.

That said, the reasoning makes sense, the manual indeed does not mention the flag and the patch is concise, so I say LGTM! :D

@Riteo
Copy link
Contributor

Riteo commented Mar 1, 2024

anyways, do you already have a working fork or are you fixing as you stumble upon compiler errors?

@akien-mga akien-mga changed the title fix FileAccessUnix on OpenBSD: there is no UF_HIDDEN Fix FileAccessUnix on OpenBSD where UF_HIDDEN isn't supported Mar 1, 2024
@omar-polo
Copy link
Contributor Author

omar-polo commented Mar 1, 2024

@Riteo yup, there are both Godot 3.x and 4.x packages for OpenBSD. We maintain some local patches that when relevant (and time permitting) send individually as PR :)

@rfht
Copy link
Contributor

rfht commented Mar 2, 2024

We have a working port on OpenBSD that includes this patch to actually build it. (read-only GH mirror at: https://github.com/openbsd/ports/tree/master/games/godot4)

@akien-mga akien-mga merged commit 0064370 into godotengine:master Mar 4, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants