Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document environment glow restrictions in the Compatibility rendering method #89059

Merged
merged 1 commit into from
Mar 4, 2024

Conversation

Calinou
Copy link
Member

@Calinou Calinou commented Mar 1, 2024

Note: Not cherry-pickable as glow in Compatibility is only implemented in 4.3.

@Calinou Calinou requested a review from a team as a code owner March 1, 2024 18:55
@Calinou Calinou added this to the 4.3 milestone Mar 1, 2024
@Calinou Calinou force-pushed the doc-glow-compatibility branch from d462b4f to ce1b63f Compare March 1, 2024 18:57
Copy link
Member

@AThousandShips AThousandShips left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

doc/classes/Environment.xml Show resolved Hide resolved
doc/classes/Environment.xml Outdated Show resolved Hide resolved
@Calinou Calinou force-pushed the doc-glow-compatibility branch from ce1b63f to d0b54b1 Compare March 1, 2024 19:02
Copy link
Member

@clayjohn clayjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@ettiSurreal
Copy link
Contributor

I'll add, maybe glow_blend_mode should mention what is it equivalent to?

@Calinou
Copy link
Member Author

Calinou commented Mar 2, 2024

I'll add, maybe glow_blend_mode should mention what is it equivalent to?

I believe glow is always using the Add blend mode in Compatibility, but I'm not 100% sure. cc @BastiaanOlij

@BastiaanOlij
Copy link
Contributor

I'll add, maybe glow_blend_mode should mention what is it equivalent to?

I believe glow is always using the Add blend mode in Compatibility, but I'm not 100% sure. cc @BastiaanOlij

I used the calculation for soft light though it ends up being applied stronger due to the way the glow buffers are created.

Copy link
Contributor

@BastiaanOlij BastiaanOlij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@akien-mga akien-mga merged commit c5577b7 into godotengine:master Mar 4, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

@Calinou Calinou deleted the doc-glow-compatibility branch March 4, 2024 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Environment.glow_enabled states it's unsupported in Compatibility rendering.
6 participants