-
-
Notifications
You must be signed in to change notification settings - Fork 21.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document environment glow restrictions in the Compatibility rendering method #89059
Conversation
d462b4f
to
ce1b63f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
ce1b63f
to
d0b54b1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
I'll add, maybe |
I believe glow is always using the Add blend mode in Compatibility, but I'm not 100% sure. cc @BastiaanOlij |
I used the calculation for soft light though it ends up being applied stronger due to the way the glow buffers are created. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Thanks! |
Environment.glow_enabled
states it's unsupported in Compatibility rendering. #89054.Note: Not cherry-pickable as glow in Compatibility is only implemented in 4.3.