GDScript: Fix paths in ResourceFormatLoaderGDScript::load()
#89005
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
approved these changes
Feb 29, 2024
adamscott
approved these changes
Feb 29, 2024
|
Needs rebase. |
dalexeev
force-pushed
the
gds-fix-res-format-loader-path
branch
from
23c3968 to
0908ad4
Compare
|
The rebase seems to have been done. |
|
CI literally just finished ;) |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resource, FQCN and
GDScriptCacheuse canonical paths. I'm not sure if we fixed all the regressions, but I tried to check as much as possible. At least the bug described in the linked comment is not reproduced.