[Doc] Clarify some details about deferred calls #88961
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AThousandShips
added
enhancement
documentation
cherrypick:4.1
KoBeWi
approved these changes
Feb 28, 2024
Mickeon
reviewed
Feb 28, 2024
AThousandShips
force-pushed
the
deferred_doc
branch
from
389fda0 to
1cc5b0a
Compare
Mickeon
approved these changes
Feb 28, 2024
|
Wasn't exactly fine as it was wrong, that was part of the improvement, but important bit was adding it to |
|
Thanks! |
|
Thank you! |
|
Cherry-picked for 4.2.2. |
akien-mga
removed
cherrypick:4.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added information directly to
Callable.call_deferredas while this information is given inObject.call_deferredit is a bit too important information to have behind a "see also". Made the details about infinite recursion to the two descriptions, and removed an incorrect statement. Calling deferred like this can't cause the game to freeze, it simply crashes as the message queue runs out of space, otherwise nothing will happen unless you just have a lot of processing going on which will freeze the game regardless of using deferred calls or not.