Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Windows: Implement dialog_show and dialog_input_text for DisplayServer #88957

Merged
merged 1 commit into from
Mar 5, 2024
Merged

Windows: Implement dialog_show and dialog_input_text for DisplayServer #88957

merged 1 commit into from
Mar 5, 2024

Conversation

398utubzyt
Copy link
Contributor

Implements DisplayServer::dialog_show and DisplayServer::dialog_input_text (currently MacOS-exclusive) for DisplayServerWindows with the Common Controls API. See below:

DisplayServer::dialog_show

button.input.dialog.mp4

DisplayServer::dialog_input_text

text.input.dialog.mp4

@398utubzyt 398utubzyt requested review from a team as code owners February 28, 2024 13:03
@398utubzyt 398utubzyt changed the title Windows: Implement native button and input text dialogs Windows: Implement dialog_show and dialog_input_text for DisplayServer Feb 28, 2024
bruvzg
bruvzg reviewed Feb 28, 2024
View reviewed changes
platform/windows/display_server_windows.cpp Outdated Show resolved Hide resolved
platform/windows/display_server_windows.cpp Outdated Show resolved Hide resolved
platform/windows/display_server_windows.cpp Outdated Show resolved Hide resolved
platform/windows/display_server_windows.cpp Outdated Show resolved Hide resolved
platform/windows/display_server_windows.cpp Outdated Show resolved Hide resolved
platform/windows/display_server_windows.cpp Outdated Show resolved Hide resolved
@398utubzyt 398utubzyt force-pushed the windows/native-dialogs branch from a990414 to b9b9041 Compare February 28, 2024 14:16
@398utubzyt 398utubzyt requested a review from bruvzg February 28, 2024 14:23
@AThousandShips AThousandShips added this to the 4.x milestone Feb 28, 2024
@398utubzyt 398utubzyt force-pushed the windows/native-dialogs branch from b9b9041 to e3e38e5 Compare February 28, 2024 20:51
@398utubzyt 398utubzyt requested a review from Mickeon February 28, 2024 20:51
Mickeon
Mickeon reviewed Feb 28, 2024
View reviewed changes
Copy link
Contributor

@Mickeon Mickeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve of the docs now, but of course I can't say much about the actual implementation. Way out of my league.

bruvzg
bruvzg reviewed Mar 4, 2024
View reviewed changes
Copy link
Member

@bruvzg bruvzg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything else seems to be fine.

platform/windows/godot_res.rc Show resolved Hide resolved
@398utubzyt 398utubzyt force-pushed the windows/native-dialogs branch from e3e38e5 to 0b021da Compare March 4, 2024 10:21
@398utubzyt 398utubzyt requested a review from bruvzg March 4, 2024 10:22
@akien-mga akien-mga modified the milestones: 4.x, 4.3 Mar 4, 2024
AThousandShips
AThousandShips approved these changes Mar 4, 2024
View reviewed changes
platform/windows/display_server_windows.cpp Outdated Show resolved Hide resolved
platform/windows/display_server_windows.cpp Outdated Show resolved Hide resolved
platform/windows/display_server_windows.cpp Outdated Show resolved Hide resolved
platform/windows/display_server_windows.cpp Outdated Show resolved Hide resolved
platform/windows/display_server_windows.cpp Outdated Show resolved Hide resolved
platform/windows/display_server_windows.cpp Outdated Show resolved Hide resolved
platform/windows/display_server_windows.cpp Outdated Show resolved Hide resolved
platform/windows/display_server_windows.cpp Outdated Show resolved Hide resolved
platform/windows/display_server_windows.cpp Outdated Show resolved Hide resolved
platform/windows/display_server_windows.cpp Outdated Show resolved Hide resolved
@398utubzyt 398utubzyt force-pushed the windows/native-dialogs branch from 0b021da to 9950061 Compare March 4, 2024 20:53
@akien-mga akien-mga merged commit 2862cb1 into godotengine:master Mar 5, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

@398utubzyt 398utubzyt mentioned this pull request Mar 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mickeon Mickeon Mickeon left review comments

@AThousandShips AThousandShips AThousandShips approved these changes

@bruvzg bruvzg bruvzg approved these changes

Assignees
No one assigned
Labels
enhancement platform:windows topic:porting
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.
5 participants
@398utubzyt @akien-mga @bruvzg @Mickeon @AThousandShips