Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove self includes in some files #88918

Merged
merged 1 commit into from
Feb 27, 2024
Merged

Conversation

blackbird806
Copy link
Contributor

It seems that rendering_device.h is including himself, so I just removed that.

@blackbird806 blackbird806 requested a review from a team as a code owner February 27, 2024 15:57
@AThousandShips AThousandShips changed the title removed self include in rendering_device.h Remove self include in rendering_device.h Feb 27, 2024
@AThousandShips AThousandShips added this to the 4.3 milestone Feb 27, 2024
@akien-mga
Copy link
Member

Good catch. I found a bunch more, so I'll amend this PR or make a new one to fix them all.

$ for file in $(find -type f -name "*.h" | sed -e "s,\./,," | sort); do res1=$(grep "^#include \"$file\"" $file); res2=$(grep "^#include \"$(basename $file)\"" $file); if [ ! -z "$res1" -o ! -z "$res2" ]; then echo -e "\n$file"; echo $res1 $res2; fi; done

modules/navigation/nav_agent.h
#include "nav_agent.h"

scene/resources/world_2d.h
#include "scene/resources/world_2d.h"

servers/rendering/rendering_device.h
#include "servers/rendering/rendering_device.h"

thirdparty/cvtt/ConvectionKernels_BC6H_IO.h
#include "ConvectionKernels_BC6H_IO.h"

thirdparty/d3d12ma/D3D12MemAlloc.h
#include "D3D12MemAlloc.h"

thirdparty/mbedtls/library/mps_trace.h
#include "mps_trace.h"

thirdparty/vulkan/vk_mem_alloc.h
#include "vk_mem_alloc.h" #include "vk_mem_alloc.h" #include "vk_mem_alloc.h" #include "vk_mem_alloc.h" #include "vk_mem_alloc.h" #include "vk_mem_alloc.h"

@akien-mga akien-mga changed the title Remove self include in rendering_device.h Remove self includes in some files Feb 27, 2024
@akien-mga akien-mga merged commit ea982c4 into godotengine:master Feb 27, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks! And congrats for your first merged Godot contribution 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants