-
-
Notifications
You must be signed in to change notification settings - Fork 21.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show instantiating or inherit message when using drag to instantiate in 2D #88829
Show instantiating or inherit message when using drag to instantiate in 2D #88829
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested locally, it works as expected.
However, there's an issue: if you drag-and-drop onto an empty scene, a new inherited scene is created. This is intended engine behavior which only currently applies to the 2D editor. This operation doesn't care about the position you drag-and-dropped the scene in, so it shouldn't display the position and should display a message of this form instead:
Creating inherited scene from: filename.tscn
Like this? 2024-02-26.17-40-02.mp4I think it's better to use the full path, because you can have multiple scenes with the same name in different folders. Also, if you just drag a sprite into an empty scene that will become the root. |
Looks great!
That makes sense 🙂 |
bdcb7ad
to
284bda8
Compare
284bda8
to
92af9eb
Compare
Code in video after feedback applied, and PR and commit renamed. |
92af9eb
to
8875ff0
Compare
Thanks! |
Related to: #88774 and #87621
See bottom left corner of editor viewport.
2024-02-25.13-38-01.mp4