Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show instantiating or inherit message when using drag to instantiate in 2D #88829

Merged

Conversation

ryevdokimov
Copy link
Contributor

Related to: #88774 and #87621

See bottom left corner of editor viewport.

2024-02-25.13-38-01.mp4

Copy link
Member

@Calinou Calinou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, it works as expected.

However, there's an issue: if you drag-and-drop onto an empty scene, a new inherited scene is created. This is intended engine behavior which only currently applies to the 2D editor. This operation doesn't care about the position you drag-and-dropped the scene in, so it shouldn't display the position and should display a message of this form instead:

Creating inherited scene from: filename.tscn

@ryevdokimov
Copy link
Contributor Author

ryevdokimov commented Feb 26, 2024

Like this?

2024-02-26.17-40-02.mp4

I think it's better to use the full path, because you can have multiple scenes with the same name in different folders. Also, if you just drag a sprite into an empty scene that will become the root.

@Calinou
Copy link
Member

Calinou commented Feb 26, 2024

Looks great!

I think it's better to use the full path, because you can have multiple scenes with the same name in different folders. Also, if you just drag a sprite into an empty scene that will become the root.

That makes sense 🙂

@ryevdokimov ryevdokimov changed the title Show instantiating message with position when using to drag to instantiate in 2D Show instantiating or inherit message when using to drag to instantiate in 2D Feb 26, 2024
@ryevdokimov
Copy link
Contributor Author

Code in video after feedback applied, and PR and commit renamed.

@akien-mga akien-mga changed the title Show instantiating or inherit message when using to drag to instantiate in 2D Show instantiating or inherit message when using drag to instantiate in 2D Feb 27, 2024
@akien-mga akien-mga modified the milestones: 4.x, 4.3 Feb 27, 2024
@akien-mga akien-mga merged commit 6d8ca17 into godotengine:master Feb 27, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants