Fix toggling a plugin makes its name black #88817
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryevdokimov
approved these changes
Feb 25, 2024
Mickeon
force-pushed
the
plugin-list-black
branch
from
da8fd78 to
4d6bf44
Compare
|
Thank you kindly for taking your time and testing this yourself. Welp. That was annoyingly worse and I cannot compile this for myself at the moment. |
|
Oh, was it supposed to go grey when toggled off? I was comparing it to 4.2 behavior. |
|
Yes. Correct. That's the intended behavior. |
|
Got it, I'll give it another look after the checks are complete. |
|
Looks good now: 2024-02-25.13-16-05.mp4 |
ryevdokimov
approved these changes
Feb 25, 2024
AThousandShips
approved these changes
Feb 27, 2024
akien-mga
approved these changes
Feb 27, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #88714 (not tested)