Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the text editor theme not being applied on editor start #88742

Merged
merged 1 commit into from
Feb 27, 2024

Conversation

MajorMcDoom
Copy link
Contributor

Fixes #88713

This was likely a regression caused by #88474 .

@MajorMcDoom MajorMcDoom requested review from a team as code owners February 23, 2024 23:08
@Mickeon Mickeon requested a review from KoBeWi February 24, 2024 00:18
@Mickeon Mickeon added this to the 4.3 milestone Feb 24, 2024
Copy link
Contributor

@Mickeon Mickeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oopsie.

editor/code_editor.cpp Show resolved Hide resolved
editor/code_editor.cpp Outdated Show resolved Hide resolved
@MajorMcDoom
Copy link
Contributor Author

Hate to admit it but I'm a little out of my depths here. That rebase definitely left me feeling very unsure. Could someone with more experience do a proper fix for this bug? I don't want to accidentally introduce other issues.

@KoBeWi
Copy link
Member

KoBeWi commented Feb 25, 2024

By "rebase" I was referring to my PR #69032, which might've actually introduced the issue. The is_generated_theme_outdated() is used in a code path that doesn't involve editor settings, so I think it changed when I rebased my PR and I missed that it's no longer needed here. Deleting the condition is probably sufficient to fix the issue (I didn't test though).

@akien-mga akien-mga merged commit e770a38 into godotengine:master Feb 27, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Script Editor errors are white
4 participants