Fix shared exported variables of inherited scenes #88741
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamscott
added
bug
topic:core
cherrypick:4.2
exodrifter
reviewed
Feb 24, 2024
adamscott
force-pushed
the
fix-shared-variables-of-inherited-scenes-redux
branch
from
9997543 to
d53a1b0
Compare
|
While this works, I wonder why is it even necessary. Why the issue happens in the first place, and only for inherited scenes? |
From what I remember, it's because inherited scenes will use the same Variant of the parent if we're not careful. |
|
CC @godotengine/gdscript |
But when creating more instances should ensure duplication of variables. Like, when you have 2 instances with exported Dictionary then it's unique, but when these instances use inherited scene, the same variable is suddenly shared. |
KoBeWi
approved these changes
May 7, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the "shared" exported variables of inherited scenes.
Supersedes
Supersedes #88739.
MRP
Many thanks to @exodrifter for her MRP.
dictionary-aliasing.zip
Notes to merging team
I added the label
cherrypick:4.2, but this may break projects if they are "exploiting" the bug, ie. fake static variables.Fixes
Fixes #81526.