Fix some additional errors with 3D disabled #88704
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
approved these changes
Feb 23, 2024
|
Gonna add some minor fixes to error prints that just clutters, intended behavior Edit: These are actually 3D only classes so will remove those tests Edit 2: Done, will look at some of the |
AThousandShips
force-pushed
the
no_3d_fix_2
branch
from
a02f9ce to
b11fe34
Compare
AThousandShips
force-pushed
the
no_3d_fix_2
branch
from
b11fe34 to
dd68b9e
Compare
* Disabled 2D navigation tests as they do not work * Disabled tests for primitive meshes * Unbound some `Mesh` methods that rely on 3D resources * Unexposed `World3D` as it depends on physics (and isn't useful) * Unexposed some `Viewport` vrs related properties that had unexposed methods
AThousandShips
force-pushed
the
no_3d_fix_2
branch
from
dd68b9e to
3a707b1
Compare
AThousandShips
commented
Feb 23, 2024
Comment on lines
+357
to
+359
| #ifndef _3D_DISABLED | ||
| Engine::get_singleton()->add_singleton(Engine::Singleton("PhysicsServer3D", PhysicsServer3D::get_singleton(), "PhysicsServer3D")); | ||
| #endif // _3D_DISABLED |
There was a problem hiding this comment.
This is only accidentally included via world_3d.h but it's broken and will likely crash (haven't tested if it does)
|
Thanks! |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Meshmethods that rely on 3D resourcesWorld3Das it depends on physics (and isn't useful)Viewportvrs related properties that had unexposed methodsWith these changes tests run equivalently in
template_debugto the normal build, and with the tests forClassDBthis should indicate that all the methods exposed in this build works correctly at least in that their arguments and return values are exposed typesEdit: Fixed some includes