Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Fix NOTIFICATION_WM_SIZE_CHANGED firing if the size hasn't changed" #88643

Merged
merged 1 commit into from
Feb 22, 2024
Merged

Revert "Fix NOTIFICATION_WM_SIZE_CHANGED firing if the size hasn't changed" #88643

merged 1 commit into from
Feb 22, 2024

Conversation

YeldhamDev
Copy link
Member

Reverts #84151. Welp, I tried.

I still think this should be tackled sometime, as the NOTIFICATION_WM_SIZE_CHANGED notification fires an unnecessarily amount of times. But alas, there's stuff that currently relies on the faulty behavior.

Fixes #86767.

@YeldhamDev YeldhamDev added this to the 4.3 milestone Feb 21, 2024
@YeldhamDev YeldhamDev requested a review from a team as a code owner February 21, 2024 18:37
@YeldhamDev
Revert "Fix NOTIFICATION_WM_SIZE_CHANGED firing if the size hasn't …
584a6ae 
…changed"

This reverts commit 957378a, reversing
changes made to 0d88840.
@YeldhamDev YeldhamDev changed the title Revert "Fix NOTIFICATION_WM_SIZE_CHANGED firing if the size hasn't changed" Revert "Fix NOTIFICATION_WM_SIZE_CHANGED firing if the size hasn't changed" Feb 21, 2024
akien-mga
akien-mga approved these changes Feb 22, 2024
View reviewed changes
Copy link
Member

@akien-mga akien-mga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, let's retry later if we can fix the faulty behavior.

@akien-mga akien-mga merged commit 5ce436f into godotengine:master Feb 22, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

@YeldhamDev YeldhamDev deleted the too_bad branch February 22, 2024 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
bug regression topic:editor topic:gui
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.

Dialog content goes outside window
2 participants
@YeldhamDev @akien-mga