-
-
Notifications
You must be signed in to change notification settings - Fork 21.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Display a warning if device CPU architecture is not active in the export preset. #88611
Display a warning if device CPU architecture is not active in the export preset. #88611
Conversation
5a98ce2
to
b58ba6e
Compare
b58ba6e
to
293c34a
Compare
I also tried to intercept the 'freeze' somehow. It gets stuck at logcat
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This updated approach looks good to me!
I wonder if it's worth adding an additional Fix and run
button to the confirm dialog to automatically add the missing architecture as your previous approach was doing, though that may make the UX looks busy.
cc @Calinou Any thoughts on the UX used in this PR?
This should be done if we want to provide a "Run Remote Debug anyway" button, as the button is unlikely to work otherwise. This is even more the case with Android 14 and later which is no longer able to run 32-bit ARM apps on 64-bit ARM devices (to my knowledge). |
I think |
Thanks! |
|
Fixes #86284
Editor crash / freeze (with arm32 devices) are prevented by selecting the correct device CPU architecture. It should also be more user-friendly. #86284 (comment)