Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to hide grid per viewport #88584

Merged

Conversation

ryevdokimov
Copy link
Contributor

Implements: godotengine/godot-proposals#9037

Related to: #87793

2024-02-20.01-29-16.mp4

@ryevdokimov ryevdokimov requested a review from a team as a code owner February 20, 2024 06:30
@Chaosus Chaosus added this to the 4.3 milestone Feb 20, 2024
Copy link
Contributor

@Mickeon Mickeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh, it makes sense in hindsight. Now it's a matter of thinking whether this is desired or not.
On a whim I'd say yes, and it doesn't look like this PR affects the existing, "global" toggle.
That menu is getting awfully tall though...

@ryevdokimov
Copy link
Contributor Author

whether this is desired or not.

Fair. I personally use this feature along with #87793 and "View Gizmos" off to create a free flying game camera that can make micro adjustments for complex dynamic scenes while using a separate viewport that does have all of that stuff enabled to provide additional when context from a different angle when needed.

That menu is getting awfully tall though...

Agreed.

Not as bad as the editor language menu though. Personally, I think some of the menus in the editor need to be reworked in general for reasons like in: godotengine/godot-proposals#8883

Copy link
Contributor

@Mickeon Mickeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to approve in principle, based on what I said before. There's nothing particularly odd about this PR. (still needs review from 3D editor team)

Copy link
Member

@akien-mga akien-mga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't test, but the feature makes sense to me and the code looks straightforward.

@ryevdokimov ryevdokimov force-pushed the hide_grid_per_viewport branch from 56aff52 to df43154 Compare February 23, 2024 15:25
@akien-mga akien-mga merged commit fd788d7 into godotengine:master Feb 23, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants