Fix AnimationMixer breaking animations with redundant check #88557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also change `Node::get_node_and_resource` to prevent it from printing an error from `Node::get_node`, and just returns nullptr. This is what the redundant check was trying to prevent. Fixes godotengine#88428. Co-authored-by: Rémi Verschelde <[email protected]>
TokageItLab
approved these changes
Feb 19, 2024
|
Thanks @TCROC, @monxa and @personalmountains for the work tracking this down! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also change
Node::get_node_and_resourceto prevent it from printing an error fromNode::get_node, and just returns nullptr. This is what the redundant check was trying to prevent.(I would have force pushed #88554 with the
get_node_and_resourcechanges, but the fork it's made from doesn't allow force pushes on PR branches.)