[Tests] Fix test regression without editor #88449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AThousandShips
commented
Feb 17, 2024
Comment on lines
+276
to
+282
| #ifdef TOOLS_ENABLED | ||
| if (name.find("[Editor]") != -1) { | ||
| Engine::get_singleton()->set_editor_hint(true); | ||
| EditorPaths::create(); | ||
| EditorSettings::create(); | ||
| } | ||
| #endif // TOOLS_ENABLED |
There was a problem hiding this comment.
Unsure if we should error here when not using a tools build just to warn, didn't add anything right now but can do if desired
akien-mga
approved these changes
Feb 17, 2024
|
Thanks! |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regression from:
undefined referenceerrors during debug template compilation #88439