Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash with animation audio track offset #88446

Merged
merged 1 commit into from
Feb 17, 2024

Conversation

AThousandShips
Copy link
Member

See #86661 (comment)

Ensures that the stream is valid (and disables the menu option if there are no valid keys)

editor/animation_track_editor.cpp Outdated Show resolved Hide resolved
editor/animation_track_editor.cpp Outdated Show resolved Hide resolved
editor/animation_track_editor.cpp Outdated Show resolved Hide resolved
Copy link
Member

@TokageItLab TokageItLab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the following up!

@AThousandShips
Copy link
Member Author

It was a good coincidence that I was working on some of the UI here and had to verify the behavior of this option for ellipses, or I wouldn't have touched this

@akien-mga akien-mga merged commit 4ce5e26 into godotengine:master Feb 17, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

@AThousandShips AThousandShips deleted the audio_key_fix branch February 17, 2024 17:34
@AThousandShips
Copy link
Member Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants