Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Remote Nodes missing custom icons #88427

Merged

Conversation

CrayolaEater
Copy link
Contributor

@CrayolaEater CrayolaEater commented Feb 17, 2024

BEFORE:

image

AFTER:

image

This PR also fixes the type hint for Remote Nodes:
image

Closes godotengine/godot-proposals#2084
Fixes #95209

@CrayolaEater CrayolaEater requested a review from a team as a code owner February 17, 2024 04:17
@akien-mga akien-mga changed the title Fixed Remote Nodes missing custom icons Fix Remote Nodes missing custom icons Feb 17, 2024
@AThousandShips AThousandShips added this to the 4.3 milestone Feb 17, 2024
@CrayolaEater CrayolaEater force-pushed the fix-no-icons-on-remote-nodes branch 3 times, most recently from 3627cbf to 5b6eb2b Compare February 17, 2024 12:54
Copy link
Member

@AThousandShips AThousandShips left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No reason to use StringName here when one of the cases is a String and the method takes a String

@CrayolaEater CrayolaEater force-pushed the fix-no-icons-on-remote-nodes branch from 5b6eb2b to 473254c Compare February 17, 2024 15:20
@Mickeon
Copy link
Contributor

Mickeon commented Feb 17, 2024

I approve of this but I cannot speak on behalf of the debugger team.

It's unfortunate that the Remote Tree is a completely different thing from the opened Scene display, because code duplication like the one in the PR is required. I considered merging the two someday but it's an very, very daunting task.

@jaydensipe
Copy link
Contributor

This will close godotengine/godot-proposals#2084 and #95209 when merged.

@CrayolaEater CrayolaEater force-pushed the fix-no-icons-on-remote-nodes branch from 38f4417 to fb58ea6 Compare October 15, 2024 19:29
@CrayolaEater CrayolaEater requested a review from a team as a code owner October 15, 2024 19:29
@Repiteo Repiteo merged commit 7f108cf into godotengine:master Oct 16, 2024
20 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Oct 16, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants