-
-
Notifications
You must be signed in to change notification settings - Fork 21.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Remote Nodes missing custom icons #88427
Fix Remote Nodes missing custom icons #88427
Conversation
3627cbf
to
5b6eb2b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No reason to use StringName
here when one of the cases is a String
and the method takes a String
5b6eb2b
to
473254c
Compare
I approve of this but I cannot speak on behalf of the debugger team. It's unfortunate that the Remote Tree is a completely different thing from the opened Scene display, because code duplication like the one in the PR is required. I considered merging the two someday but it's an very, very daunting task. |
473254c
to
38f4417
Compare
This will close godotengine/godot-proposals#2084 and #95209 when merged. |
38f4417
to
fb58ea6
Compare
Thanks! |
BEFORE:
AFTER:
This PR also fixes the type hint for Remote Nodes:

Closes godotengine/godot-proposals#2084
Fixes #95209