-
-
Notifications
You must be signed in to change notification settings - Fork 21.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Export: Unify settings for PC texture formats, removed obsoleted ETC feature #88325
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -287,7 +287,7 @@ static Ref<Image> load_from_file_access(Ref<FileAccess> f, Error *r_error) { | |
ktxfmt = KTX_TTF_BC7_RGBA; | ||
} else if (RS::get_singleton()->has_os_feature("s3tc")) { | ||
ktxfmt = KTX_TTF_BC1_RGB; | ||
} else if (RS::get_singleton()->has_os_feature("etc")) { | ||
} else if (RS::get_singleton()->has_os_feature("etc2")) { | ||
ktxfmt = KTX_TTF_ETC1_RGB; | ||
Comment on lines
+290
to
291
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I kept
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The color data encoding is ETC1 for all of them anyway, so there should not be any quality difference. |
||
} else { | ||
ktxfmt = KTX_TTF_RGBA32; | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed this, which is redundant with the above logic, and also wrong if users for some reason decide to export ETC2/ASTC and not S3TC/BPTC.