Add is_visible_in_tree in TreeItem
#88300
Merged
+44
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FaycalElOuariachi
force-pushed
the
add-TreeItem-is_visible_in_tree
branch
2 times, most recently
from
31b4b56 to
8b276fb
Compare
Mickeon
approved these changes
Feb 14, 2024
There was a problem hiding this comment.
Documentation is just fine
This bugfix makes sense. is_visible_in_tree, akin to CanvasItem and Node3D is likely to benefit many and the internal editor code for things like the Scene Tree dock.
However, there's now 3 (possibly more?) Objects that share this similar snippet of code. I don't know if that's going to be a good thing in the long run.
FaycalElOuariachi
force-pushed
the
add-TreeItem-is_visible_in_tree
branch
from
8b276fb to
2121fca
Compare
KoBeWi
reviewed
Feb 25, 2024
KoBeWi
reviewed
Feb 25, 2024
FaycalElOuariachi
force-pushed
the
add-TreeItem-is_visible_in_tree
branch
from
2121fca to
50cf7e1
Compare
KoBeWi
approved these changes
Mar 5, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addind a member
is_visible_in_treeinTreeItem, which returnstrueif the item and all its ancestors are visible.This fixes #88251
Each
TreeItem, after visibility changes, propagate its state to its children.Some uses of
TreeItem::is_visibleare replaced by the newTreeItem::is_visible_in_tree(I did my best to analyze which ones should be replaced or not).Tested with the minimal repoduction project attached to the corresponding issue #88251
Here is a slightly modified version, where we can turn on and off the visibility of some
TreeItemwith keyboard (1 to 9 normal and numpad keys)Tree Item-is_visible_in_tree.zip
Video captures :
(master)
TreeItem.-.is_visible.bug.mp4
(fix)
TreeItem.-.is_visible.fix.mp4