Improve AnimationMixer warnings #88247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KoBeWi
force-pushed
the
warning_pinpointer_20000
branch
from
d582141 to
154b4a5
Compare
fire
approved these changes
Feb 12, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ever since AnimationMixer was added, I'm getting bothered by animation warnings from interpolation mismatch. They come from various scenes and need to be fixed on by one, but the warning does not provide any context other than animation name, so sometimes it's difficult to poinpoint what caused the warning.
After checking it again on master I think they were a bit loosened, but just in case I decided to tweak them a bit to make them easier to find.
This PR adds scene name (if available) to the warnings coming from AnimationMixer:
