Link xid_start and xid_continue externally to prevent data duplication in binary
#88203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
changed the title
xid_start and xid_continue externally to prevent data duplication in binary
akien-mga
approved these changes
Feb 11, 2024
bruvzg
approved these changes
Feb 11, 2024
AThousandShips
changed the title
xid_start and xid_continue externally to prevent data duplication in binaryxid_start and xid_continue externally to prevent data duplication in binary
|
Would you mind updating the commit message as this isn't hash related :) |
Listwon
force-pushed
the
char-range-build-size
branch
from
d2e0251 to
5ee4b49
Compare
AThousandShips
approved these changes
Feb 11, 2024
|
@AThousandShips You are right, I mixed it with hash table commit message, thanks :D |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similarly to #88178
xid_startandxid_continuewere reported in SizeBench.Windows 11, Microsoft (R) C/C++ Optimizing Compiler Version 19.38.33133 for x64
scons target=template_releasebuild size reduced by 22 KB.