-
-
Notifications
You must be signed in to change notification settings - Fork 21.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix duplicating/copying TileMap
#88105
Fix duplicating/copying TileMap
#88105
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
It seems this is relatively trivial, will look at a different fix leveraging Edit: Better solution, will push momentarily |
cfdb835
to
23197cb
Compare
Using `force_parent_owned` to prevent issues duplicating
23197cb
to
85d9c23
Compare
I've identified a few other places where |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree this solution is better. In the future, though, if/when layers are exposed, these snippets should be removed, otherwise you get into a nasty bug. Maybe adding a comment on the side can help?
They shouldn't be removed even then, the layers would be doubled because the recreation of the data from the properties, I didn't realise that in my first attempt but it had extra layers because the map doesn't detect them being added, granted with more such details that would work but alone these lines shouldn't be removed even if the layer is exposed |
Thanks! |
Thank you! |
Using
force_parent_owned
to prevent issues duplicatingThink this covers all cases
TileMap
can't be duplicated or copied in editor #88104