[Font] Allow overriding advances, offsets and kerning in the ImageFont import settings. #88088
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mickeon
reviewed
Feb 12, 2024
There was a problem hiding this comment.
ooOOooooo making textured font addons less needed by the day. Exciting
bruvzg
force-pushed
the
img_font_more
branch
from
6e02633 to
cbeb918
Compare
Mickeon
approved these changes
Feb 12, 2024
There was a problem hiding this comment.
Documentation is just fine. I cannot speak for the implementation itself.
The feature does enhance Bitmap fonts by a notable margin. It is also notably inspired by many existing 3.x addons that implement something similar. Most notably https://github.com/ElectronicBlueberry/Texture-Fonts.
It is of course extremely unfortunate that there's no dedicated UI that streamlines this process or completely overhauls it, but it is better than nothing.
Mickeon
reviewed
Feb 12, 2024
akien-mga
approved these changes
Feb 13, 2024
…t import settings. Fix bitmap font kerning override.
bruvzg
force-pushed
the
img_font_more
branch
from
cbeb918 to
42ec133
Compare
|
Thanks! |
This was referenced Feb 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, there's no convenient UI for setting values, but it can be added as an advanced import dialog.
Bugsquad edit: